Rename @jupyterlab/server-proxy to @jupyterhub/jupyter-server-proxy #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/rename-labext
branch
from
f5640e3 to
d138801
Compare
manics
reviewed
Jan 3, 2023
manics
reviewed
Jan 3, 2023
Maybe, but I'd like to uncouple that discussion from this PR. In my mind, we should if several other projects stop supporting lab2 also. |
Co-authored-by: Simon Li <[email protected]>
consideRatio
force-pushed
the
pr/rename-labext
branch
from
90f0ff4 to
54e6910
Compare
|
@manics I rebased to resolve a merge conflict. No changes was made besides that in the force push. |
|
OK! I'll leave it to @bollwyvl to check and merge. |
|
Sorry I missed this earlier. The changes look fine, and I'm +1 on merging it as-is, with perhaps some iteration on (partial) ideas on #370 before doing a full release. |
bollwyvl
approved these changes
Jan 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jupyterlab/server-proxyto@jupyterhub/jupyter-server-proxy#363@jupyterhub/jupyter-server-proxyand generated an access token.jupyterlab-server-proxytolabextensionfor readability now that the extension is named the same as the python package