Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test against modern python versions and fix broken test suite #348

Merged
merged 4 commits into from
Nov 2, 2022
Merged

ci: test against modern python versions and fix broken test suite #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66552df
ci: test againsts oldest/newest python version
consideRatio Nov 1, 2022
c4588b2
ci: add comment linking to reference about .robot files
consideRatio Nov 2, 2022
e068a7f
ci: ensure colors in for robot in github workflows
consideRatio Nov 2, 2022
43ee556
ci: set JUPYTER_CONFIG_DIR to pick up config in acceptance tests
consideRatio Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
# specified below, these parameters have no meaning on their own and
# gain meaning on how job steps use them.
jupyterlab_version: [2, 3]
python: [3.6, 3.7, 3.8, 3.9]
python: ["3.6", "3.11"]
jupyter_app: [notebook, lab]

steps:
Expand Down
4 changes: 4 additions & 0 deletions tests/acceptance/Classic.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
*** Comments ***
To learn more about these .robot files, see
https://robotframework-jupyterlibrary.readthedocs.io/en/stable/.

*** Settings ***
Documentation Server Proxies in Notebook Classic
Library JupyterLibrary
Expand Down
4 changes: 4 additions & 0 deletions tests/acceptance/Lab.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
*** Comments ***
To learn more about these .robot files, see
https://robotframework-jupyterlibrary.readthedocs.io/en/stable/.

*** Settings ***
Documentation Server Proxies in Lab
Library JupyterLibrary
Expand Down
7 changes: 7 additions & 0 deletions tests/acceptance/__init__.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
*** Comments ***
To learn more about these .robot files, see
https://robotframework-jupyterlibrary.readthedocs.io/en/stable/.

*** Settings ***
Documentation Acceptance tests for jupyter-server-proxy
Library JupyterLibrary
Expand All @@ -9,6 +13,9 @@ Suite Teardown Clean Up
Set Up
${notebook dir} = Set Variable ${OUTPUT DIR}${/}notebooks
Copy Directory resources ${notebook dir}
Set Environment Variable
... name=JUPYTER_CONFIG_DIR
... value=${notebook dir}
Wait For New Jupyter Server To Be Ready
... stdout=${OUTPUT DIR}${/}server.log
... notebook_dir=${notebook dir}
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/test_acceptance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def test_robot():
shutil.rmtree(OUTPUT)

return_code = subprocess.call(
[*map(str, ["robot", "--outputdir", OUTPUT, HERE])],
["robot", "--consolecolors=on", f"--outputdir={OUTPUT}", str(HERE)],
cwd=str(HERE)
)

Expand Down