Reduce (and test) sdist size #263
Conversation
|
Looks like having |
.github/workflows/test.yaml
Outdated
| - name: Check Package Sizes | ||
| run: | | ||
| ls -lathr dist | ||
| find dist -type f -size +200k | grep dist || echo ok |
There was a problem hiding this comment.
Is this just for info, or should it fail if there's a file > 200k ? At the moment the exit code will always be 0 regardless.
There was a problem hiding this comment.
yeah, i need to figure out how to make it fail properly. will try some more stuff locally.
There was a problem hiding this comment.
should be fully resolved by 33b424c
|
Sorry for the thrash (feel free to squash merge):
|
There was a problem hiding this comment.
Sorry for the delay, LGTM.
Is everyone else happy with the addition of yarn.lock? dependabot will update it, but they'll ber loads of PRs, e.g. see https://github.com/manics/jupyter-offlinenotebook/pulls?q=is%3Apr+is%3Aclosed+label%3Ajavascript
This hardly seems like a bad thing... anyhow, any thoughts here, folks? That big ol' tarball is still out there burning bits-on-the-wire... |
|
I guess silence is acquiescence? 😄 Could you help we with one question- what's the expectation when it comes to merging dependabot PRs to |
|
The cheapest acceptance test is dev-focused binder, which seems useful anyway. If you want full acceptance testing, I'm happy to spin up some robotframework-jupyterlibrary which can test classic and lab (and watch the server logs) and generate nice reports. If this is a blocking concern, I can take out the yarn.lock, and have even less assurance that the extension works. |
|
I've added #268 |
|
Congrats on your first merged pull request in this project! 🎉 |
The 3.0.2 sdist clocks in at 43.3M.
This PR explicitly removes the
node_modulesfrom the sdist by updating MANIFEST.in, bringing the.tar.gzdown to 82k, and adds a check in the publish CI (with a >2x margin for future growth).To maintain reproducibility, it removes
yarn.lockfrom.gitignore, which despite the commit thrash, is actually quite useful in tracking down where something might have changed, and will also save re-solving in CI.