Merge pull request #348 from consideRatio/pr/test-against-modern-pyth…

…on-versions ci: test against modern python versions and fix broken test suite
jupyterhub · Nov 2, 2022 · 0208c09 · 0208c09
2 parents 798160e + 43ee556
commit 0208c09
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 2 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -37,7 +37,7 @@ jobs:
         # specified below, these parameters have no meaning on their own and
         # gain meaning on how job steps use them.
         jupyterlab_version: [2, 3]
-        python: [3.6, 3.7, 3.8, 3.9]
+        python: ["3.6", "3.11"]
         jupyter_app: [notebook, lab]
 
     steps:

diff --git a/tests/acceptance/Classic.robot b/tests/acceptance/Classic.robot
@@ -1,3 +1,7 @@
+*** Comments ***
+To learn more about these .robot files, see
+https://robotframework-jupyterlibrary.readthedocs.io/en/stable/.
+
 *** Settings ***
 Documentation     Server Proxies in Notebook Classic
 Library           JupyterLibrary

diff --git a/tests/acceptance/Lab.robot b/tests/acceptance/Lab.robot
@@ -1,3 +1,7 @@
+*** Comments ***
+To learn more about these .robot files, see
+https://robotframework-jupyterlibrary.readthedocs.io/en/stable/.
+
 *** Settings ***
 Documentation     Server Proxies in Lab
 Library           JupyterLibrary

diff --git a/tests/acceptance/__init__.robot b/tests/acceptance/__init__.robot
@@ -1,3 +1,7 @@
+*** Comments ***
+To learn more about these .robot files, see
+https://robotframework-jupyterlibrary.readthedocs.io/en/stable/.
+
 *** Settings ***
 Documentation     Acceptance tests for jupyter-server-proxy
 Library           JupyterLibrary
@@ -9,6 +13,9 @@ Suite Teardown    Clean Up
 Set Up
     ${notebook dir} =    Set Variable    ${OUTPUT DIR}${/}notebooks
     Copy Directory    resources    ${notebook dir}
+    Set Environment Variable
+    ...    name=JUPYTER_CONFIG_DIR
+    ...    value=${notebook dir}
     Wait For New Jupyter Server To Be Ready
     ...    stdout=${OUTPUT DIR}${/}server.log
     ...    notebook_dir=${notebook dir}

diff --git a/tests/acceptance/test_acceptance.py b/tests/acceptance/test_acceptance.py
@@ -15,7 +15,7 @@ def test_robot():
         shutil.rmtree(OUTPUT)
 
     return_code = subprocess.call(
-        [*map(str, ["robot", "--outputdir", OUTPUT, HERE])],
+        ["robot", "--consolecolors=on", f"--outputdir={OUTPUT}", str(HERE)],
         cwd=str(HERE)
     )