Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a shared clipboard #10

Merged
merged 3 commits into from
Jan 14, 2023
Merged

Add a shared clipboard #10

merged 3 commits into from
Jan 14, 2023

Conversation

manics
Copy link
Member

@manics manics commented Jul 23, 2021

Adds a textarea that acts as a shared bi-directional clipboard. This is based on vnc.html:

image

@github-actions
Copy link

Binder 👈 Launch a binder notebook on this branch for commit cda1899

@manics
Copy link
Member Author

manics commented Jul 23, 2021

This also means you can share the link to the current instance with a browser inside itself 😄
image

@satra
Copy link

satra commented Oct 29, 2021

it would be really nice to get this merged.

@fperez
Copy link

fperez commented Jan 28, 2022

Thanks @yuvipanda for pointing me here! Glad to see there's a start on this one - it's not absolutely critical, but will become a bigger and bigger annoyance the more we try to do "on the inside" of the hubs.

I've resorted to using the hub's firefox a lot more precisely so I can move information around, since at least inside this does work fine...

@github-actions
Copy link

Binder 👈 Launch a binder notebook on this branch for commit 67a8425

@yuvipanda yuvipanda merged commit 24a2568 into jupyterhub:main Jan 14, 2023
@yuvipanda
Copy link
Contributor

Just tested this, and it seems to work :) We can work on the styling later! Thanks a lot, @manics!

@manics manics deleted the clipboard branch January 15, 2023 19:56
@fperez
Copy link

fperez commented Jan 19, 2023

Many thanks! Has this been released? I was just about to freshen the stat159 image and it would be nice to have this finally solved :)

@yuvipanda
Copy link
Contributor

@fperez not yet, but maybe there may be one tomorrow! #20 (comment)

@fperez
Copy link

fperez commented Jan 19, 2023

Awesome, thx!

@yuvipanda
Copy link
Contributor

@fperez done! It has a different name though - https://pypi.org/project/jupyter-remote-desktop-proxy/

@fperez
Copy link

fperez commented Jan 20, 2023

Awesome, thx!! I just updated the stat159 env, can I replace jupyter-desktop-server==0.1.3with jupyter-remote-desktop-proxy==1.0.0 now?

And if so, do you have a conda package for it yet, or should I go with pip for the time being?

cc @shaneknapp @balajialg in case this update is useful for other hubs than 159.

@yuvipanda
Copy link
Contributor

@fperez yep, just that change would do. It is a bit complex to package on conda, might be a while! So still gotta use pip

@fperez
Copy link

fperez commented Jan 20, 2023

Thx Yuvi, np!

@satra
Copy link

satra commented Jan 20, 2023

thanks @yuvipanda - just incorporated into dandihub. required the websockify piece from conda-forge as instructed in the readme. will be very helpful to folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants