Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpful message on public url to app, configured like _CLIENT_ID #4

Closed
consideRatio opened this issue Jan 25, 2022 · 1 comment · Fixed by #16
Closed

Helpful message on public url to app, configured like _CLIENT_ID #4

consideRatio opened this issue Jan 25, 2022 · 1 comment · Fixed by #16

Comments

@consideRatio
Copy link
Member

I've not gone through the full steps, but wouldn't it be nice to have a standardized UX for how users would go about knowing what app to authorize against etc?

I figure we would configure the public url (in my case https://github.com/settings/apps/hub-jupytearth-org-github-integ), just like we configure the GITHUB_APP_CLIENT_ID env var. While it isn't crucial, it would allow this software to provide helpful messages to the user if they aren't already setup or similar maybe?

Another options would perhaps be to let this software lookup the public URL by knowing the APP id by asking some GitHub API?

@yuvipanda
Copy link
Collaborator

yuvipanda commented Jan 25, 2022

Yah, asking the GitHub API and providing that URL would be perfect. If not, it would definitely be great to allow that to be configured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants