-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
propagation support for bind mounts (once docker-py supports it officially) #494
base: main
Are you sure you want to change the base?
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
docker/docker-py#3164 has been merged via docker/docker-py@0f0b20a |
`rshared`,`shared`,`rprivate`, `private`, `rslave`, `slave`. | ||
default is `rprivate`. | ||
This is only interpreted by docker-py if patched (see: | ||
https://github.com/jannefleischer/docker-py/commit/786d55de465e72d0bb4b318272a2d020e43ff54a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it required a manual patch, I would not consider this patch appropriate for this project, but since it's merged, can you reference the required version of docker-py here? It's not clear to me what that is.
Just a heads up: From 7.0.0b2 and forward the propagation thingy is supported. - but its still pre-release. |
docker-py 7.0 is published officially, which includes the support for propagation: https://github.com/docker/docker-py/releases/tag/7.0.0 - so this pr could be merged if a new dependency on docker-py 7.0.0 is ok. |
bringing v4 back to my fork
I added a pull request for propagation support in docker-py (docker/docker-py#3164) which has to be accepted before this PR makes any sense.
Also I just realized that there seem to be other options (Mount specs???) in dockerspawner to enable propagation, but since documentation of docker-py is sparse, I couldn't figure out how to use that...
This might be helpful for others that want to use autofs in their jupyter-container launched by dockerspawner.