Add tests against dockerd on the host system (k8s cordining/uncording not tested) #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
force-pushed
the
tests
branch
2 times, most recently
from
813dfab to
285219b
Compare
for more information, see https://pre-commit.ci
|
(Min I'm working this actively atm) |
It seems that the image builds doesn't add to the space detected by the image cleaner in our test setup. If we don't run pytest as sudo, we get 0.0GB of space reported, and if we use sudo, I get 0.1GB of space reported - never more. I've tried using docker:20-dind and docker:24-dind without difference. I think the key question is to figure out where in the dind container the built images get saved.
consideRatio
changed the title
|
@minrk I couldn't stay away from the mystery, it was solved by replacing /dev/zero with /dev/urandom, use of nocache=True passed to the build also didn't do the trick. I opened the following as part of working on this: |
consideRatio
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Pweh tests as passing and makes sense to me, feel free to go for a merge or push changes and then merge @minrk!
|
Wonderful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
started working on these, but it immediately became difficult to run tests locally because I haven't been able to get docker-in-docker to work with a mounted docker directory (presumably a docker-on-mac issue). Shouldn't be a problem on true linux, though.
closes #16