Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] playwright snapshots #6726

Closed
wants to merge 3 commits into from
Closed

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Feb 9, 2023

Follow-up to #6724

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Binder 👈 Launch a Binder on branch jtpio/notebook/playwright-tests

@jtpio
Copy link
Member Author

jtpio commented Feb 9, 2023

bot please update playwright snapshots

@jtpio
Copy link
Member Author

jtpio commented Feb 9, 2023

OK this seems to be working now.

The first commit updated the Chromium snapshots:

image

The second the Firefox snapshots:

image

@jtpio
Copy link
Member Author

jtpio commented Feb 9, 2023

Although we are hitting the same issue as in JupyterLab with the CI not being triggered: jupyterlab/jupyterlab#13505

@jtpio jtpio closed this Feb 9, 2023
@jtpio jtpio reopened this Feb 9, 2023
@jtpio jtpio added this to the 7.0 milestone Feb 9, 2023
@jtpio
Copy link
Member Author

jtpio commented Feb 9, 2023

Closing since this was mostly for testing the workflow.

@jtpio jtpio closed this Feb 9, 2023
@jtpio jtpio deleted the playwright-tests branch February 9, 2023 14:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant