Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall nbclassic on Binder so Notebook v7 can load #6505

Merged
merged 4 commits into from
Aug 4, 2022
Merged

Uninstall nbclassic on Binder so Notebook v7 can load #6505

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e0b522
Try force reinstalling on Binder
jtpio Aug 4, 2022
bc81087
uninstall nbclassic
jtpio Aug 4, 2022
a8ef6d7
Update postBuild
jtpio Aug 4, 2022
6ba4251
Add comment about uninstall nbclassic
jtpio Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion binder/postBuild
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
#!/bin/bash
set -euo pipefail

python -m pip install -e .
python -m pip install -e . --force-reinstall

# TODO: remove when it's possible to install nbclassic next to Notebook v7
# without nbclassic shadowing the v7 endpoints
python -m pip uninstall nbclassic -y

jlpm && jlpm run build
jlpm run develop