Fix #3182: use unique attachment key to allow multiple image paste pe… #3821
Conversation
|
Test failure fixed. |
| @@ -354,9 +354,9 @@ define([ | |||
| // We generate names for blobs | |||
| var key; | |||
| if (blob.name !== undefined) { | |||
| key = encodeURIandParens(blob.name); | |||
| key = utils.uuid() + '_' + encodeURIandParens(blob.name); | |||
There was a problem hiding this comment.
I think we should avoid UUIDs. They can be a problem when added to documents. Instead, collisions can be detected and avoided through a counter suffix.
There was a problem hiding this comment.
Don't cells already have UUIDs?
There was a problem hiding this comment.
No, they don't. UUIDs are carefully avoided in the document format.
Looking now, there is a vestigial cell_id attribute in the code that shouldn't be present and isn't used for anything.
|
This is seriously limiting the utility of notebooks for my usecase. Any chance we can get a compromise solution here? |
|
Is this fixed, but not yet released? Pasting two images still does not work. |
|
As @minrk said above, we don't want to add UUIDs to cells. Closing this one as out of date. |
…r cell