Adding file size to views

notebook/services/api/api.yaml

@@ -814,6 +814,10 @@ definitions:
         type: string
         description: Last modified timestamp
         format: dateTime
+      size:
+        type: integer
+        description: "The size of the file or directory."
+        format: bytes
       mimetype:
         type: string
         description: "The mimetype of a file.  If content is not null, and type is 'file', this will contain the mimetype of the file, otherwise this will be null."

notebook/services/contents/filemanager.py

@@ -183,6 +183,15 @@ def is_hidden(self, path):
         os_path = self._get_os_path(path=path)
         return is_hidden(os_path, self.root_dir)
 
+    def _get_file_size(self, path):
+        try:
+            # size of file
+            size = os.path.getsize(path)
+        except (ValueError, OSError):
+            self.log.warning('Unable to get size.')
+            size = None
+        return size
+
     def file_exists(self, path):
         """Returns True if the file exists, else returns False.
 
@@ -270,6 +279,7 @@ def _base_model(self, path):
         model['content'] = None
         model['format'] = None
         model['mimetype'] = None
+
         try:
             model['writable'] = os.access(os_path, os.W_OK)
         except OSError:
@@ -333,6 +343,7 @@ def _dir_model(self, path, content=True):
 
         return model
 
+
     def _file_model(self, path, content=True, format=None):
         """Build a model for a file
 
@@ -348,6 +359,7 @@ def _file_model(self, path, content=True, format=None):
 
         os_path = self._get_os_path(path)
         model['mimetype'] = mimetypes.guess_type(os_path)[0]
+        model['size'] = self._get_file_size(os_path)
 
         if content:
             content, format = self._read_file(os_path, format)
@@ -373,13 +385,16 @@ def _notebook_model(self, path, content=True):
         """
         model = self._base_model(path)
         model['type'] = 'notebook'
+        os_path = self._get_os_path(path)
+        model['size'] = self._get_file_size(os_path)
+
         if content:
-            os_path = self._get_os_path(path)
             nb = self._read_notebook(os_path, as_version=4)
             self.mark_trusted_cells(nb, path)
             model['content'] = nb
             model['format'] = 'json'
             self.validate_notebook_model(model)
+
         return model
 
     def get(self, path, content=True, type=None, format=None):

notebook/static/base/js/utils.js

@@ -1038,7 +1038,34 @@ define([
             return (order == 1) ? 1 : -1;
         }
     };
+
+    // source: https://github.com/sindresorhus/pretty-bytes
+    var format_filesize = function(num) {
+      if (num === undefined)
+        return;
+
+      var UNITS = ['B', 'kB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB'];
+
+      if (!Number.isFinite(num)) {
+        console.error(`Expected a finite number, got ${typeof num}: ${num}`);
+      }
+
+      var neg = num < 0;
 
+      if (neg) {
+        num = -num;
+      }
+
+      if (num < 1) {
+        return (neg ? '-' : '') + num + ' B';
+      }
+
+      var exponent = Math.min(Math.floor(Math.log10(num) / 3), UNITS.length - 1);
+      var numStr = Number((num / Math.pow(1000, exponent)).toPrecision(3));
+      var unit = UNITS[exponent];
+
+      return (neg ? '-' : '') + numStr + ' ' + unit;
+    }
 
     // javascript stores text as utf16 and string indices use "code units",
     // which stores high-codepoint characters as "surrogate pairs",
@@ -1180,6 +1207,7 @@ define([
         parse_b64_data_uri: parse_b64_data_uri,
         time: time,
         format_datetime: format_datetime,
+        format_filesize: format_filesize,
         datetime_sort_helper: datetime_sort_helper,
         dnd_contain_file: dnd_contain_file,
         js_idx_to_char_idx: js_idx_to_char_idx,

notebook/static/tree/js/notebooklist.js

@@ -62,9 +62,34 @@ define([
         });
     }
 
+    function size_sorter(ascending) {
+        var order = ascending ? 1 : 0;
+        // directories have file size of undefined
+        return (function(a, b) {
+          if (a.size === undefined) {
+             return (ascending) ? -1 : 1;
+          }
+
+          if (b.size === undefined) {
+             return (ascending) ? 1 : -1;
+          }
+
+          if (a.size > b.size) {
+            return (ascending) ? -1 : 1;
+          }
+
+          if (b.size > a.size) {
+            return (ascending) ? 1 : -1;
+          }
+
+          return 0;
+        });
+    }
+
     var sort_functions = {
         'sort-name': name_sorter,
-        'last-modified': modified_sorter
+        'last-modified': modified_sorter,
+        'file-size': size_sorter
     };
 
     var NotebookList = function (selector, options) {
@@ -520,6 +545,11 @@ define([
             .addClass("item_name")
             .appendTo(link);
 
+        $("<span/>")
+            .addClass("file_size")
+            .addClass("pull-right")
+            .appendTo(item);
+
         $("<span/>")
             .addClass("item_modified")
             .addClass("pull-right")
@@ -835,6 +865,7 @@ define([
         // Add in the date that the file was last modified
         item.find(".item_modified").text(utils.format_datetime(model.last_modified));
         item.find(".item_modified").attr("title", moment(model.last_modified).format("YYYY-MM-DD HH:mm"));
+        item.find(".file_size").html(utils.format_filesize(model.size) || "&nbsp;");
     };
 
 

notebook/static/tree/less/tree.less

@@ -167,6 +167,10 @@ ul.breadcrumb {
     margin-left: @dashboard_lr_pad;
 }
 
+.file_size{
+    width: 65px;
+}
+
 [dir="rtl"] .item_modified.pull-right{
     .pull-left();
 }

notebook/templates/tree.html

@@ -117,6 +117,12 @@
                 {% endfor %}
                 </ul>
               </div>
+              <div id="file_size" class="pull-right sort_button">
+                  <span class="btn btn-xs btn-default sort-action" id="file-size">
+                      {% trans %}File size{% endtrans %}
+                      <i class="fa"></i>
+                  </span>
+              </div>
               <div id="last_modified" class="pull-right sort_button">
                   <span class="btn btn-xs btn-default sort-action" id="last-modified">
                       {% trans %}Last Modified{% endtrans %}