fix:when upload large file,we cant stop #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
reviewed
Feb 26, 2018
| @@ -1220,12 +1220,14 @@ define([ | |||
| NotebookList.prototype.add_large_file_upload_button = function (file) { | |||
| var that = this; | |||
| var item = that.new_item(0, true); | |||
| var stop_singnal = false; | |||
There was a problem hiding this comment.
Ping @forbxy - can you make this spelling change?
| @@ -1276,6 +1278,9 @@ define([ | |||
| var upload_file = null; | |||
|
|
|||
| var large_reader_onload = function (event) { | |||
| if (stop_singnal === true) { | |||
| return; | |||
There was a problem hiding this comment.
Should this also abort the file reader? https://developer.mozilla.org/en-US/docs/Web/API/FileReader/abort
There was a problem hiding this comment.
file reader is a local variable，one chunk one file reader var，we stopped before new file reader create (after last chunk uploaded)， so we don't need to abort file reader
There was a problem hiding this comment.
should I make a commit to fix the word(singnal)?or it is already changed after you review?
There was a problem hiding this comment.
You'll need to make a commit to fix it - my comment was just pointing it out.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the cancel button' action only remove its html item, don't stop upload event before