-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hidden prompt overlay button #2681
Conversation
@minrk Mind taking a look at this? Just wanna make sure that this doesn't behave unexpectedly in some edge case. |
Let's try it to see if it has side effects. |
I think this is right. I saw this when I did my PR, but then forgot to investigate. |
FYI, this breaks the For now, we'll just hardcode some css to hide the prompt area in output widgets. I think it would be enough to check |
Proposed fix: #2961 |
Closes #2590
It looks like
this.collapsed
is returningfalse
and thereforethis.prompt_overlay.show()
is not being called: https://github.com/jupyter/notebook/blob/master/notebook/static/notebook/js/outputarea.js#L155