Make keyboard shortcuts declarative #1234
Conversation
| this._remove_leaf(shortcut, this._shortcuts); | ||
| if (!suppress_help_update) { | ||
| // update the keyboard shortcuts notebook help | ||
| this.events.trigger('rebuild.QuickHelp'); | ||
| } | ||
| } catch (ex) { | ||
| console.warn('shortbut', shortcut, '...',this._shortcuts); |
|
A few minor comments, but 👍 |
|
Is this API compatible? Sent from my iPhone
|
With what ? |
|
@willingc added a bit of documentation. Can I get your feedback on it ? |
More especially: it is purely an addition of a config section. It maps what user were doing in their There is 0 API deletion, 0 API addition, 0 API modification. Just the provisional (added in the docs) addition of a config section in the docs. So I'm not sure what your question of API compatibility means. |
|
|
||
| DEclarative Custom Keymaps is a provisional feature with unstable API which is not | ||
| guarantied to be keep in future versions odf the notebook, and can be | ||
| removed or changed without warnings. |
There was a problem hiding this comment.
spelling nits:
DEclarative -> Declarative
guarantied -> guaranteed
be keep -> be kept
odf -> of
|
All updated. |
Make keyboard shortcuts declarative
|
Thanks! |
|
@Carreau Thanks! I'll give a look at the content now that it's merged. Spent yesterday cleaning up the other notebook stuff. |
look in config for
keys.command.unbind,keys.edit.unbindfor which shortcuts to unbind,then
keys.command.bind,keys.edit.bindfor new shortcut to bind.Done after feedback at JupyterDays.
Command Palette hover of Shortcut area show the action name as a tooltip so that users know what to bind.
Cleanup Js here and there, and replace
(command)in command palette with(command mode)to remove confusion with Cmd keys on Mac.