Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.5 #3591

Closed
9 tasks done
gnestor opened this issue May 2, 2018 · 17 comments
Closed
9 tasks done

Release 5.5 #3591

gnestor opened this issue May 2, 2018 · 17 comments

Comments

@gnestor
Copy link
Contributor

gnestor commented May 2, 2018

To do:

@gnestor
Copy link
Contributor Author

gnestor commented May 2, 2018

@takluyver Can I help with publishing releases, announcements, etc?

@gnestor gnestor added this to the 5.5 milestone May 2, 2018
@takluyver
Copy link
Member

Please do! I've put the RC out on PyPI and emailed the jupyter list to advertise it. I think we should give that a few days before doing the final release, but if you can think of any other ways to get more people to try the RC, that would be welcome.

Brian also mentioned that he'd seen an issue with leaking file descriptors, but I don't even know how to monitor that, so any investigation is welcome.

@gnestor
Copy link
Contributor Author

gnestor commented May 3, 2018

Brian also mentioned that he'd seen an issue with leaking file descriptors, but I don't even know how to monitor that, so any investigation is welcome.

@ellisonbg How can I reproduce this?

@kevin-bates
Copy link
Member

I'm interested in the FD leak as well. Although not directly related to FDs, there were a couple jupyter_client PRs (360, 361 - referenced in #3424) that might be worth grabbing to see if this still can be reproduced. That said, since this appears to be new, I doubt there's a relationship.

@takluyver
Copy link
Member

@kevin-bates do you know how to monitor an FD leak? If you can try to investigate that would be valuable.

@ellisonbg
Copy link
Contributor

ellisonbg commented May 3, 2018 via email

@kevin-bates
Copy link
Member

For my testing, I primarily focused on memory leaks (using instrumentation) but also monitored socket (fd) usage via: ls -l /proc/<jupyter pid>/fd | grep socket | wc -l during kernel start/stop sequences (although I didn't [and don't] see anything wrt fd leaks). For a single kernel I see the socket counts consistent at 23 and 7 depending on whether its running or not.

@takluyver
Copy link
Member

I played around with starting and stopping kernels while monitoring /proc/.../fd for the notebook server, and I couldn't reproduce an obvious leak. The count seemed to stabilise at 24 fds. So I think we can leave that until someone can clearly reproduce it.

@takluyver
Copy link
Member

5.5.0 is now out on PyPI. I'll wait to see if the conda-forge auto update bot handles the update there.

@gnestor
Copy link
Contributor Author

gnestor commented May 9, 2018

@takluyver Do you want to wait until conda-forge is updated before announcing on Google Group or blog?

@ellisonbg
Copy link
Contributor

ellisonbg commented May 10, 2018 via email

@gnestor
Copy link
Contributor Author

gnestor commented May 15, 2018

I have created a draft blog post: https://blog.jupyter.org/jupyter-notebook-5-5-0-17b2e2d4f7f

Anyone care to review/publish?

@damianavila
Copy link
Member

Anyone care to review/publish?

LGTM, but I do not have permissions to publish it.

@takluyver
Copy link
Member

The first bullet point is a bit confusing:

Download as… menu item for nbconvert exporters

There already were menu items for nbconvert exporters. But whereas we previously showed only a fixed list, we now add menu entries for any exporters that have the export_from_notebook attribute set to a string. That's trickier to explain; I might take it out of the headline features list.

Other than that, feel free to publish it whenever you're ready.

@takluyver
Copy link
Member

I see it was published, so closing this issue. Thanks @gnestor :-)

@gnestor
Copy link
Contributor Author

gnestor commented May 27, 2018

I updated with "Dynamic Download as… menu for nbconvert exporters." @takluyver feel free edit if necessary 👍

@takluyver
Copy link
Member

I don't think I have access to the blog - and I'm fine with this, there's plenty of things to do already.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants