Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify NotebookNotary._data_dir_default #378

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

cmd-ntrf
Copy link
Contributor

The code for that function originally predates the introduction of the function jupyter_core.paths.jupyter_data_dir which can now be used to determine the Jupyter data directory instead of initializing an instance of JupyterApp just to figure its data directory.

I figure this out while working on another PR for jupyter_server_fileid which uses the function to determine the data directory : https://github.com/jupyter-server/jupyter_server_fileid/blob/v0.9.0/jupyter_server_fileid/manager.py#L23

cmd-ntrf and others added 2 commits September 14, 2023 10:28
The code for that function originally predates the introduction of
the function `jupyter_core.paths.jupyter_data_dir` which can now
be used to determine the Jupyter data directory instead of initializing
an instance of JupyterApp just to figure its data directory.
Copy link
Member

@ivanov ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup @cmd-ntrf !

@ivanov ivanov enabled auto-merge (squash) November 16, 2023 01:47
@ivanov ivanov merged commit 0708dd6 into jupyter:main Nov 16, 2023
24 checks passed
krassowski added a commit to krassowski/nbformat that referenced this pull request Mar 13, 2024
ivanov pushed a commit that referenced this pull request Mar 13, 2024
* Revert PR #378 (Simplify NotebookNotary._data_dir_default)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants