Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strip_invalid_metadata argument to validator normalize method #355

Merged
merged 1 commit into from
Mar 19, 2023

Conversation

jonabc
Copy link
Contributor

@jonabc jonabc commented Mar 16, 2023

👋 This update adds the strip_invalid_metadata argument to the public normalize method, passing the argument into the nonpublic _normalize method rather than always passing false.

The reason behind this change is that the _normalize method only uses the relax_add_props argument when strip_invalid_metadata is true. That argument is currently hardcoded to false by normalize, making the relax_add_props argument functionality unused. By allowing callers to specify strip_invalid_metadata, there is at least a chance that the relax_add_prop argument will also be used.

I didn't see any tests in this project related to the normalize method, so I wasn't sure what might be needed for tests.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 85917af into jupyter:main Mar 19, 2023
@jonabc jonabc deleted the patch-1 branch March 20, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants