Only require nbformat_minor for v4 #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these notebooks exist in the wild and there is only one nbformat minor for v3, so there is no ambiguity. It's more important for real notebooks to be readable than perfect validation be satisfied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#237 made some public notebooks unreadable. There is only one nbformat minor for v3, so there is no ambiguity here. It's more important for real notebooks to be readable than perfect validation be satisfied.
For example, this is linked from the nbviewer front page and started to fail because of #237: https://nbviewer.org/gist/fonnesbeck/2352771