Strip metadata that is causing notebook validation to fail #245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a kwarg to
validate
:strip_invalid_metadata
, which when set to True will introspect into schema failures during validation and will attempt to remove top-level metadata keys for the cell or notebook that are failing validation.Specifically what this mechanism does:
Potential issues that might block merging this as-is:
schema_index = schemas_by_index.index(f"#/definitions/{intended_cell_type}_cell")
. If the definitions changed their convention this would break.fastjsonschema
because it relies on introspection intojsonschema.ValidationErrors
. We coercefastjsonschema
errors intojsonschema.ValidationErrors
but those errors lack some of the context I think is necessary to traverse correctly.I think long-term, this general strategy could be merged into #236.