Fix lint (#336)

* fix lint * lint
jupyter · Dec 16, 2022 · 73a10a5 · 73a10a5
1 parent a6c1ee9
commit 73a10a5
Show file tree

Hide file tree

Showing 10 changed files with 7 additions and 14 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -34,7 +34,7 @@ repos:
       - id: black
 
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: v0.0.165
+    rev: v0.0.180
     hooks:
       - id: ruff
         args: ["--fix"]
diff --git a/nbformat/sign.py b/nbformat/sign.py
@@ -528,7 +528,7 @@ def check_cells(self, nb):
         return trusted
 
 
-trust_flags = {
+trust_flags: dict = {
     "reset": (
         {"TrustNotebookApp": {"reset": True}},
         """Delete the trusted notebook cache.

diff --git a/nbformat/v1/nbbase.py b/nbformat/v1/nbbase.py
@@ -18,7 +18,6 @@
 
 from .._struct import Struct
 
-
 # -----------------------------------------------------------------------------
 # Code
 # -----------------------------------------------------------------------------

diff --git a/nbformat/v1/nbjson.py b/nbformat/v1/nbjson.py
@@ -21,7 +21,6 @@
 from .nbbase import from_dict
 from .rwbase import NotebookReader, NotebookWriter
 
-
 # -----------------------------------------------------------------------------
 # Code
 # -----------------------------------------------------------------------------

diff --git a/nbformat/v2/convert.py b/nbformat/v2/convert.py
@@ -19,7 +19,6 @@
 
 from .nbbase import new_code_cell, new_notebook, new_text_cell, new_worksheet
 
-
 # -----------------------------------------------------------------------------
 # Code
 # -----------------------------------------------------------------------------

diff --git a/nbformat/v2/nbbase.py b/nbformat/v2/nbbase.py
@@ -23,7 +23,6 @@
 
 from .._struct import Struct
 
-
 # -----------------------------------------------------------------------------
 # Code
 # -----------------------------------------------------------------------------

diff --git a/nbformat/v2/nbjson.py b/nbformat/v2/nbjson.py
@@ -22,7 +22,6 @@
 from .nbbase import from_dict
 from .rwbase import NotebookReader, NotebookWriter, rejoin_lines, restore_bytes, split_lines
 
-
 # -----------------------------------------------------------------------------
 # Code
 # -----------------------------------------------------------------------------

diff --git a/nbformat/v2/rwbase.py b/nbformat/v2/rwbase.py
@@ -18,7 +18,6 @@
 
 from base64 import decodebytes, encodebytes
 
-
 # -----------------------------------------------------------------------------
 # Code
 # -----------------------------------------------------------------------------

diff --git a/pyproject.toml b/pyproject.toml
@@ -54,8 +54,6 @@ test = [
     "pre-commit",
     "pep440"
 ]
-lint = ["black[jupyter]>=22.6.0", "mdformat>0.7", "ruff>=0.0.156"]
-typing = ["mypy>=0.990"]
 
 [project.scripts]
 jupyter-trust = "nbformat.sign:TrustNotebookApp.launch_instance"
@@ -82,12 +80,14 @@ test = "python -m pytest -vv --cov nbformat --cov-branch --cov-report term-missi
 nowarn = "test -W default {args}"
 
 [tool.hatch.envs.typing]
-features = ["typing", "test"]
+features = ["test"]
+dependencies = ["mypy>=0.990"]
 [tool.hatch.envs.typing.scripts]
 test = "mypy --install-types --non-interactive {args:nbformat tests}"
 
 [tool.hatch.envs.lint]
-features = ["lint"]
+dependencies = ["black[jupyter]==22.10.0", "mdformat>0.7", "ruff==0.0.180"]
+detached = true
 [tool.hatch.envs.lint.scripts]
 style = [
   "ruff {args:.}",
@@ -172,7 +172,7 @@ ignore = [
   # Line too long
   "E501",
   # Relative imports are banned
-  "I252",
+  "TID252",
   # Boolean ... in function definition
   "FBT001", "FBT002",
   # Module level import not at top of file

diff --git a/tests/test_reader.py b/tests/test_reader.py
@@ -17,7 +17,6 @@
 
 from .base import TestsBase
 
-
 # -----------------------------------------------------------------------------
 # Classes and functions
 # -----------------------------------------------------------------------------
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,7 +18,6 @@ @@
     from .._struct import Struct
     # -----------------------------------------------------------------------------
     # Code
     # -----------------------------------------------------------------------------
@@ Expand Down @@