-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accessibility] some accessibility improvements #2021
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I'm not a user of a screenreader, so I might be missing something, but how is I don't know a solution here, but I would like to point out previous discussions: #1993, matplotlib/matplotlib#21328 |
Thanks for pointing out some discussions. I agree that it's not really useful as such. I don't think we can even tell that it's an image from matplotlib when building HTML, so I don't know neither how we can have any information about the content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I don't think that blindly satisfying the automated checks here is the right approach. This will provide a false sense of satisfying the requirements. If a notebook contains images without alt the check should error out. |
The problem comes from images generated by Matplotlib (at least), and I don't know if it can be fixed by a user currently. |
I'm cutting the release, we can follow up with further improvements in a bug fix release. |
This PR improves the accessibility of the produced HTML file, using the
HTMLExporter
:html
tag, configurable with a traittabindex="0"
to the inputs and outputs, in order to be able to navigate through the Notebook using the tab key