-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExtractAttachmentsPreprocessor #1978
Conversation
183c3bb
to
32be570
Compare
The previous iteration was fine with the tests, but it looks like the way I associated attachment directories with specific notebooks broke something. Will look into it soon. |
I am not sure what is the best way to enable this preprocessor. I initially thought of adding it to For now, I enabled it for markdown and latex exporters. |
It might be worth noting that I am aware I'll take a look to see how it works and make appropriate changes later. |
59ee3c9
to
b14e8d3
Compare
Updated with latest commits to main |
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Adds a new preprocessor to extract notebook attachments into individual files, so that conversion outputs (like
.md/.tex
files) work properly.Fixes #1977.
Todos