Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make date configurable in latex/PDF #1963

Merged
merged 3 commits into from
Apr 1, 2023
Merged

Make date configurable in latex/PDF #1963

merged 3 commits into from
Apr 1, 2023

Conversation

achimgaedke
Copy link
Contributor

@achimgaedke achimgaedke commented Mar 23, 2023

That's a working example of implementing #1962.

Fix #1962

@achimgaedke
Copy link
Contributor Author

achimgaedke commented Mar 23, 2023

Sorry, must have used the wrong template, this should have an appropriate label like 1enhancement1 or so, but I don't know how to set it.

@achimgaedke achimgaedke changed the title make date configurable in latex/PDF - #1962 Enhancement: make date configurable in latex/PDF - #1962 Mar 29, 2023
@blink1073 blink1073 changed the title Enhancement: make date configurable in latex/PDF - #1962 Make date configurable in latex/PDF Mar 31, 2023
@blink1073
Copy link
Contributor

Thanks for working on this! The changelog gets auto-generated, can you please add a note in docs/source/usage.rst instead?

@achimgaedke
Copy link
Contributor Author

@blink1073 - done, also documented the other fields, author and title.

@achimgaedke
Copy link
Contributor Author

I've added some command line options, they round the feature off nicely.

I find notebook metadata viewing/editing not very obvious, I guess this is a common fate of features becoming more important than expected.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you!

@blink1073 blink1073 merged commit 056dc4e into jupyter:main Apr 1, 2023
@blink1073
Copy link
Contributor

I'll make a release with this on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Set LaTeX/PDF document date
2 participants