html: write image/svg+xml data as base64 and skip clean_html (#2018)

Co-authored-by: Steven Silvester <[email protected]>
jupyter · Jul 15, 2023 · 8e1eae4 · 8e1eae4
1 parent f17dad8
commit 8e1eae4
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 710 deletions.
diff --git a/nbconvert/filters/strings.py b/nbconvert/filters/strings.py
@@ -41,8 +41,6 @@
     "text_base64",
 ]
 
-from nbconvert.filters.svg_constants import ALLOWED_SVG_ATTRIBUTES, ALLOWED_SVG_TAGS
-
 
 def wrap_text(text, width=100):
     """
@@ -91,11 +89,9 @@ def clean_html(element):
         kwargs['css_sanitizer'] = css_sanitizer
     return bleach.clean(
         element,
-        tags=[*bleach.ALLOWED_TAGS, *ALLOWED_SVG_TAGS, "div", "pre", "code", "span"],
-        strip_comments=False,
+        tags=[*bleach.ALLOWED_TAGS, "div", "pre", "code", "span"],
         attributes={
             **bleach.ALLOWED_ATTRIBUTES,
-            **{svg_tag: list(ALLOWED_SVG_ATTRIBUTES) for svg_tag in ALLOWED_SVG_TAGS},
             "*": ["class", "id"],
         },
         **kwargs,

diff --git a/nbconvert/filters/svg_constants.py b/nbconvert/filters/svg_constants.py