Do not import pyppeteer for installation check (#1947)Co-authored-by:…

… pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Matthias Bussonnier <[email protected]> * Do not import pyppeteer for installation check * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix lint * more details ignore type --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Matthias Bussonnier <[email protected]>
jupyter · Feb 20, 2023 · 857631d · 857631d
1 parent 7bf3fb8
commit 857631d
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/nbconvert/exporters/webpdf.py b/nbconvert/exporters/webpdf.py
@@ -7,17 +7,13 @@
 import concurrent.futures
 import os
 import tempfile
+from importlib import util as importlib_util
 
 from traitlets import Bool, default
 
 from .html import HTMLExporter
 
-try:
-    import pyppeteer  # type:ignore  # noqa
-
-    PYPPETEER_INSTALLED = True
-except ImportError:
-    PYPPETEER_INSTALLED = False
+PYPPETEER_INSTALLED = importlib_util.find_spec("pyppeteer") is not None
 
 
 class WebPDFExporter(HTMLExporter):
@@ -71,7 +67,7 @@ def _template_name_default(self):
 
     def _check_launch_reqs(self):
         try:
-            from pyppeteer import launch
+            from pyppeteer import launch  # type: ignore[import]
             from pyppeteer.util import check_chromium  # type:ignore
         except ModuleNotFoundError as e:
             msg = (