New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless code #142

Closed

Siecje wants to merge 1 commit into jupyter:master from Siecje:120

Siecje commented Oct 17, 2018

While investigating #120 I learned that this code is not needed. Without this code the same wheel is created.

If any of the packages contain a __pycache__ then it will be included in the wheel.

I'm not sure how the __pycache__ was created though. I tried installing the package and running tox and there was no __pycache__ created.


          Remove useless code

bfab93c

Member

minrk commented Oct 18, 2018

This isn't correct. This code is required to avoid excluding these files in source distributions (python setup.py sdist).

Siecje closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet