Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --simple-prompt flag #93

Closed
dsblank opened this issue Jul 14, 2016 · 2 comments
Closed

Add --simple-prompt flag #93

dsblank opened this issue Jul 14, 2016 · 2 comments
Milestone

Comments

@dsblank
Copy link
Member

dsblank commented Jul 14, 2016

As mentioned ipython/ipython#9758 (comment) jupyter_console needs a --simple-prompt flag to allow it to work inside other environments (eg, emacs).

@ajsteven130
Copy link

In emacs, people using jupyter console are using the jupyter_console_test environment variable to get simple-prompt behavior. It works well enough, but as this issue states, having the proper flag would be better. For an example, see jorgenschaefer/elpy#1041

Also, if we use exit() to close a session using the simple-prompt, we get the following error:

Traceback (most recent call last):
  File "/Users/avigan/anaconda/bin/jupyter-console", line 5, in <module>
    app.main()
  File "/Users/avigan/anaconda/lib/python3.5/site-packages/jupyter_core/application.py", line 267, in launch_instance
    return super(JupyterApp, cls).launch_instance(argv=argv, **kwargs)
  File "/Users/avigan/anaconda/lib/python3.5/site-packages/traitlets/config/application.py", line 658, in launch_instance
    app.start()
  File "/Users/avigan/anaconda/lib/python3.5/site-packages/jupyter_console/app.py", line 151, in start
    self.shell.mainloop()
  File "/Users/avigan/anaconda/lib/python3.5/site-packages/jupyter_console/ptshell.py", line 468, in mainloop
    self._eventloop.close()
AttributeError: 'NoneType' object has no attribute 'close'

Process Python exited abnormally with code 1

If the --simple-prompt flag makes it in to jypyter console, it may be good to sort out this error as well.

@takluyver
Copy link
Member

#116 adds a flag and fixes the error on exit.

@minrk minrk added this to the 5.1 milestone Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants