-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make cache_ports configurable with default value of False. #956
Conversation
This addresses issue jupyter#878 and jupyter#955.
for more information, see https://pre-commit.ci
I guess I should have added a label. I don't know what this would be considered, I guess an enhancement? |
Given the previous discussion a while ago, I view this change as something that should have been part of the original change and have applied the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you @jkitchin
Does anything else need to happen to this? |
We usually give folks a day or two to review. However, the build issue is also unwarranted but I believe it is probably unrelated. @blink1073 - is the coverage issue due to some external version update or something like that? (Sorry, I haven't been "close" to the repos lately.) |
The coverage thing is a weird artifact from switching away from codecov where it seems like |
I'll cut a new release early next week. |
Thank you Steve! |
This addresses issue #878 and #955. Suggested by @kevin-bates.