MAINT: consistently use relative imports. #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seem like jupyter_client uses a mix of absolute and relative imports, even in same files, which seem a bit weird. Normalise everything to relative imports, which should make it a bit easier to detect potential cycles, or higher-level imports. I've found 6 places that now use `..` to imports somethings, where would potentially want to make some refactor at some point in the future to not import something closer to the root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seem like jupyter_client uses a mix of absolute and relative imports, even in same files, which seem a bit weird.
Normalise everything to relative imports, which should make it a bit easier to detect potential cycles, or higher-level imports.
I've found 6 places that now use
..to imports somethings, where would potentially want to make some refactor at some point in the future to not import something closer to the root.