Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AsyncKernelClient to doc/api/client.rst #819

Merged
merged 5 commits into from
Jul 30, 2022

Conversation

helioz11
Copy link
Contributor

No description provided.

Copy link
Member

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @helioz11.
I'm wondering if it's worth adding the API of AsyncKernelClient, since it's the same as BlockingKernelClient except that it's async.
Maybe we should have the complete API for BlockingKernelClient and just say that AsyncKernelClient is identical but async?

@helioz11
Copy link
Contributor Author

Sure, how about if I move the automethod from AsyncKernelClient to BlockingKernelClient and add extra information in AsyncKernelClient?

@davidbrochart
Copy link
Member

Yes, that sounds good.

docs/api/client.rst Outdated Show resolved Hide resolved
Co-authored-by: David Brochart <[email protected]>
Copy link
Member

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @helioz11.

@davidbrochart davidbrochart merged commit 43859ae into jupyter:main Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants