Check that channels exist before asking if they are alive #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbrochart
approved these changes
May 8, 2022
There was a problem hiding this comment.
Thanks @ccordoba12, although I'm not sure how this method is used in the wild, I think that your changes are correct.
Comment on lines
+340
to
+344
| (self._shell_channel and self.shell_channel.is_alive()) | ||
| or (self._iopub_channel and self.iopub_channel.is_alive()) | ||
| or (self._stdin_channel and self.stdin_channel.is_alive()) | ||
| or (self._hb_channel and self.hb_channel.is_alive()) | ||
| or (self._control_channel and self.control_channel.is_alive()) |
There was a problem hiding this comment.
These changes seem more in line with the docstring "Are any of the channels created and running?", e.g. with only self.shell_channel.is_alive() we are creating a shell channel if it doesn't already exists, so we are only checking if it is running.
Your changes ensure that a channel already exists before checking if it is running, which seems like the right thing to do IMO.
There was a problem hiding this comment.
Thanks @davidbrochart!
|
Thanks a lot for your prompt reply @davidbrochart and for releasing 7.3.1 with my fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extra check fixes issue spyder-ide/spyder#17776 in Spyder, which appeared with Jupyter-client 7.3.0.
It only happens when Spyder is closed, but I don't understand very well why. Since it's a small patch, I hope it'll be accepted so that we don't have to subclass
QtKernelClienton our side for this.