-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename trait to allowed_kernelspecs #672
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good Steve, thank you for providing this. I just had a couple of comments. I've run with this branch and see the appropriate deprecation warning:
[W 14:52:14.292 NotebookApp] KernelSpecManager.whitelist is deprecated in JupyterLab 7.0, use KernelSpecManager.allowed_kernel_names instead
My first thought on the trait name was allowed_kernels
but I think allowed_kernel_names
is more correct. I suppose another option would be allowed_kernelspecs
so that kernel names aren't accidentally interpreted as "ipykernel" or "xeus-python", etc. i.e., the literal kernel name.
Co-authored-by: Kevin Bates <[email protected]>
Co-authored-by: Kevin Bates <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per a sidebar, I've suggested the trait name be allowed_kernelspecs
to potentially avoid ambiguity.
The title could probably use an update as well, but didn't want to assume the suggestions would be accepted. 😄
Co-authored-by: Kevin Bates <[email protected]>
Co-authored-by: Kevin Bates <[email protected]>
Co-authored-by: Kevin Bates <[email protected]>
Co-authored-by: Kevin Bates <[email protected]>
Co-authored-by: Kevin Bates <[email protected]>
Co-authored-by: Kevin Bates <[email protected]>
Thanks! I updated the title and description accordingly. |
Did we release Jupyterlab 7 already??? 😮 🎉 |
Haha fixes are welcome. 😉 |
Partially addresses #642 by deprecating
KernelSpecManager.whitelist
in favor of the more descriptive and inclusiveKernelSpecManager.allowed_kernelspecs
.