Use a default serializer that is not only for date types #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
force-pushed
the
default_serializer
branch
2 times, most recently
from
c1707ed to
d58b3f4
Compare
Carreau
reviewed
Jul 1, 2021
jupyter_client/jsonutil.py
Outdated
| """default function for packing datetime objects in JSON.""" | ||
| """DEPRECATED: Use jupyter_client.jsonutil.json_default""" | ||
| warnings.warn( | ||
| "date_default is deprecated. Use jupyter_client.jsonutil.json_default.", stacklevel=2 |
There was a problem hiding this comment.
Would you care to add a since version XXX, I don't know if you want to do 7.0 or backport. But I think that will help users to transition.
There was a problem hiding this comment.
I will do it :)
Should we do backports to 6.x.x? I would actually not mind doing it, and it's not that big of a change, and not backward-incompatible.
|
+1 |
martinRenou
force-pushed
the
default_serializer
branch
from
d58b3f4 to
62bc802
Compare
|
Is it ready to be merged? |
|
I guess I still need to process #664 (comment) But the question is what should be the comment? Should it be |
I think |
martinRenou
force-pushed
the
default_serializer
branch
from
62bc802 to
3881f9d
Compare
|
Done :) |
|
Not quite yet :-) |
martinRenou
force-pushed
the
default_serializer
branch
from
3881f9d to
cdb5fc3
Compare
This would allow making more general changes here. I am also adding serialization of bytes type into base64.
martinRenou
force-pushed
the
default_serializer
branch
from
cdb5fc3 to
1363f53
Compare
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow making more general changes here. I am also adding serialization of bytes type into base64.
For more context, this is going in the direction of ipython/ipykernel#706. This allows getting rid of the
json_cleanfunction, moving the bytes treatment from ipykernel to jupyter_client when actually doing the serializion of the object.