Refactor kernel manager tests for pytest #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSeal
approved these changes
Jul 14, 2020
| assert km.context.closed | ||
|
|
||
|
|
||
| class TestKernelManager: |
There was a problem hiding this comment.
I don't think the class is necessary btw. You can just define test functions directly.
There was a problem hiding this comment.
True. I was just keeping the classes around for organization purposes, although I did find it convenient to specify @pytest.mark.asyncio on the TestAsyncKernelManager declaration for its tests.
Do you want these removed and things flattened out?
There was a problem hiding this comment.
Nah, I agree it's helping organize here. Was just commenting in case it wasn't known. Let's merge your work :)
|
Should we kick off a patch release? |
|
Thanks for the merge @MSeal. A patch release sounds like a grand idea - thank you! |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the kernel manager tests to the pytest framework.
TestParallelwas already using pytest, so this converts the other tests.The subclasses added in #560 are now used in more tests as general subclasses and a specific subclass test now exists.
Note: There was a bug uncovered in
TestParallelwhich was not setting the transport correctly. As a result, thetcptransport was used for tests that were meant to be tested using theipctransport. Of those, the parallel thread and process tests fail usingipcand have been temporarily skipped in this PR.