Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused sphinx import in test_kernelapp #518

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

bollwyvl
Copy link
Contributor

In working on conda-forge/jupyter_client-feedstock#38 uncovered a new test dependency on sphinx which may be spurious... doesn't appear to be used, but figured PR is better than issue, if straightforward.

@bollwyvl bollwyvl changed the title [wip] remove potentially unused sphinx import in test_kernelapp remove potentially unused sphinx import in test_kernelapp Feb 24, 2020
@bollwyvl bollwyvl changed the title remove potentially unused sphinx import in test_kernelapp remove unused sphinx import in test_kernelapp Feb 24, 2020
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks Nick.

@kevin-bates kevin-bates merged commit 58e1971 into jupyter:master Feb 24, 2020
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Feb 24, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants