check that buffers are contiguous #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmq.send will fail on non-contiguous buffers ensures errors due to bad arguments are raise in `Session.send` instead of potentially delayed to the aysnc callback, which is not handled well.
Carreau
approved these changes
May 8, 2017
takluyver
reviewed
May 18, 2017
jupyter_client/session.py
Outdated
| except TypeError: | ||
| raise TypeError("Buffer objects must support the buffer protocol.") | ||
| if not view.contiguous: |
There was a problem hiding this comment.
Unfortunately Python 2.7 doesn't have this attribute:
AttributeError: 'memoryview' object has no attribute 'contiguous'
|
I manually re-ran the Python 2 test build, but the failure appears to be consistent. |
since we skip the check there, too
|
Yup, forgot to also skip the test when I skipped the check on Python 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zmq.send will fail on non-contiguous buffers
ensures errors due to bad arguments are raise in
Session.sendinstead of potentially delayed to the async callback, which is not handled well.cf ipython/ipykernel#245