-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'jupyter kernel' command #240
Conversation
Could this be tested? |
jupyter_client/kernelapp.py
Outdated
from .kernelspec import KernelSpecManager | ||
from .manager import KernelManager | ||
|
||
class KernelApp(JupyterApp): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docstrings anywhere?
Very nice! I'd love a test to get basic exercise of the signal stuff. |
Is this related to issue #32? |
Yep, it is. I've basically stopped trying to work on everything related to the 'kernel nanny' proposal (jupyter/enhancement-proposals#14) for now, though, because I don't have a good enough feel for the problem. This will probably also need to be updated in light of #261, if that goes forward. |
A simple lead in to the 'kernel nanny' work, this adds a command so you can do: jupyter kernel --kernel python
f6e9610
to
7e6d167
Compare
I've come back to this following a recent email. I've added some docstrings and a rather crude test. |
Great! Thanks for coming back to this one. |
@meeseeksdev backport |
There seem to be a conflict, please backport manually |
A simple lead in to the 'kernel nanny' work, this adds a command so you can do: ``` jupyter kernel --kernel python ``` I intend this for post-5.0. Signed-off-by: Thomas Kluyver <[email protected]>
Backported manually. |
Have you explored using |
A simple lead in to the 'kernel nanny' work, this adds a command so you can do:
I intend this for post-5.0.