Skip to content

Commit

Permalink
Merge pull request #535 from davidbrochart/fix_kill
Browse files Browse the repository at this point in the history
Subprocess kill is not async
  • Loading branch information
MSeal authored Mar 25, 2020
2 parents 28bf720 + 4430e73 commit 3ab5e5a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion jupyter_client/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ async def _kill_kernel(self):
if hasattr(signal, 'SIGKILL'):
await self.signal_kernel(signal.SIGKILL)
else:
await self.kernel.kill()
self.kernel.kill()
except OSError as e:
# In Windows, we will get an Access Denied error if the process
# has already terminated. Ignore it.
Expand Down

0 comments on commit 3ab5e5a

Please sign in to comment.