Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zulip and deduplicate BlueSky #781

Merged
merged 2 commits into from
Feb 8, 2025
Merged

Add zulip and deduplicate BlueSky #781

merged 2 commits into from
Feb 8, 2025

Conversation

RRosio
Copy link
Contributor

@RRosio RRosio commented Jan 28, 2025

I noticed that Zulip was missing from the Jupyter website and thought it could be added as the community is quite active there. I was not sure if it should be added elsewhere like the 'Follow Us' section, but I can add it there if it should indeed go there!

I also noticed the BlueSky sandwich mentioned by Paul in #780 (comment) so I thought it might work to update it here 🙂

Copy link
Member

@ivanov ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to resolve a conflict, since Matthias already deduplicated on the main branch directly.

@ivanov
Copy link
Member

ivanov commented Feb 7, 2025

pinging @jupyter/media-strategy-working-group (which I just created) to make sure they're aligned with this change.

@andrii-i
Copy link
Contributor

andrii-i commented Feb 7, 2025

Hi everyone. Thank you for working on this.
There's a "Audit with Lighthouse" test failing, is this problematic?
Other than that, this LGTM.

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good improvement. We might always improve this further but I think this is good enough to just merge as is. This is not the cause of lighthouse failures for the test so I think that's fine

@ivanov ivanov merged commit deb285c into jupyter:main Feb 8, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants