Don't override singleuser ip to 0.0.0.0 #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
approved these changes
Jan 27, 2025
benz0li
added a commit
to b-data/jupyterlab-python-docker-stack
that referenced
this pull request
Jan 27, 2025
- JupyterHub singleuser arguments are set using environment variables - jupyter/docker-stacks#2203
benz0li
added a commit
to b-data/jupyterlab-julia-docker-stack
that referenced
this pull request
Jan 27, 2025
- JupyterHub singleuser arguments are set using environment variables - jupyter/docker-stacks#2203
benz0li
added a commit
to b-data/jupyterlab-mojo-docker-stack
that referenced
this pull request
Jan 27, 2025
- JupyterHub singleuser arguments are set using environment variables - jupyter/docker-stacks#2203
benz0li
added a commit
to b-data/jupyterlab-r-docker-stack
that referenced
this pull request
Jan 27, 2025
- JupyterHub singleuser arguments are set using environment variables - jupyter/docker-stacks#2203
benz0li
added a commit
to b-data/jupyterlab-qgis-docker-stack
that referenced
this pull request
Jan 27, 2025
- JupyterHub singleuser arguments are set using environment variables - jupyter/docker-stacks#2203
|
@manics I'll merge this when tests pass, but I would be grateful if you added a test case both for this PR and previous PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
JupyterHub controls which interface(s) the singleuser server listens on.
The IP is set in the Spawner configuration, and passed to the singleuser server in the environment variable
JUPYTERHUB_SERVICE_URL:https://jupyterhub.readthedocs.io/en/latest/reference/spawners.html#note-on-ips-and-ports
Docker-stacks shouldn't override it. For example, if you configure a JupyterHub container spawner to use a docker-stacks image and use the default CMD it won't work with IPv6.
Issue ticket if applicable
Checklist (especially for first-time contributors)