Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check healthcheck in all jupyter applications #1854

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Check healthcheck in all jupyter applications #1854

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fbc9b6
Check healthcheck in all jupyter applications
mathbunnyru Jan 3, 2023
a153788
Fix
mathbunnyru Jan 3, 2023
3f25f9e
Remove JUPYTERHUB_API_TOKEN healthcheck test
mathbunnyru Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion tests/base-notebook/test_healthcheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,30 @@

import logging
import time
from typing import Optional

import pytest # type: ignore

from tests.conftest import TrackedContainer, get_health

LOGGER = logging.getLogger(__name__)


def test_health(container: TrackedContainer) -> None:
@pytest.mark.parametrize(
"env",
[
None,
["DOCKER_STACKS_JUPYTER_CMD=lab"],
["RESTARTABLE=yes"],
["DOCKER_STACKS_JUPYTER_CMD=notebook"],
["DOCKER_STACKS_JUPYTER_CMD=server"],
["DOCKER_STACKS_JUPYTER_CMD=nbclassic"],
],
)
def test_health(container: TrackedContainer, env: Optional[list[str]]) -> None:
running_container = container.run_detached(
tty=True,
environment=env,
)
# sleeping some time to let the server start
time.sleep(15)
Expand Down