Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make workflows work fine in forked repos #1845

Merged

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@@ -25,7 +25,6 @@ on:
jobs:
build-docs:
name: Build Sphinx Documentation
if: github.event_name != 'schedule' || (github.event_name == 'schedule' && github.repository == 'jupyter/docker-stacks')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should run just fine even in forked repos.

@bjornjorgensen bjornjorgensen mentioned this pull request Dec 9, 2022
4 tasks
@mathbunnyru mathbunnyru merged commit cdfd63a into jupyter:main Dec 9, 2022
@mathbunnyru
Copy link
Member Author

I guess a few more things have to be done to make it work really well:

  • disable aarch64 builds
  • be more careful with wiki updates

I will deal with these issues a bit later.

@bjornjorgensen
Copy link
Contributor

@mathbunnyru
Copy link
Member Author

@bjornjorgensen I finally made it work properly. Please, merge the latest main to your active branches if you need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants