Install jupyterhub-base instead of jupyterhub (#2171)

* Install jupyterhub-base instead of jupyterhub * Update images/base-notebook/Dockerfile --------- Co-authored-by: Ayaz Salikhov <[email protected]>
jupyter · Nov 6, 2024 · 28a0b25 · 28a0b25
1 parent 62a85b4
commit 28a0b25
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/docs/using/recipe_code/jupyterhub_version.dockerfile b/docs/using/recipe_code/jupyterhub_version.dockerfile
@@ -1,6 +1,6 @@
 FROM quay.io/jupyter/base-notebook
 
-RUN mamba install --yes 'jupyterhub==4.0.1' && \
+RUN mamba install --yes 'jupyterhub-base==4.0.1' && \
     mamba clean --all -f -y && \
     fix-permissions "${CONDA_DIR}" && \
     fix-permissions "/home/${NB_USER}"
diff --git a/images/base-notebook/Dockerfile b/images/base-notebook/Dockerfile
@@ -39,9 +39,15 @@ USER ${NB_UID}
 # files across image layers when the permissions change
 WORKDIR /tmp
 RUN mamba install --yes \
-    'jupyterhub' \
+    'jupyterhub-base' \
     'jupyterlab' \
     'nbclassic' \
+    # nodejs has historically been installed indirectly as a dependency.
+    # When it was no longer getting installed indirectly,
+    # we started installing it explicitly to avoid introducing a breaking change
+    # for users building on top of these images.
+    # See: https://github.com/jupyter/docker-stacks/pull/2171
+    'nodejs' \
     # Sometimes, when the new version of `jupyterlab` is released, latest `notebook` might not support it for some time
     # Old versions of `notebook` (<v7) didn't have a restriction on the `jupyterlab` version, and old `notebook` is getting installed
     # That's why we have to pin the minimum notebook version

diff --git a/tests/docker-stacks-foundation/test_packages.py b/tests/docker-stacks-foundation/test_packages.py
@@ -74,8 +74,10 @@
     "grpcio-status",
     "grpcio",
     "hdf5",
+    "jupyterhub-base",
     "jupyterlab-git",
     "mamba[version='<2.0.0']",
+    "nodejs",
     "notebook[version='>",
     "openssl",
     "pandas[version='>",