Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lumino classes #105

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Use lumino classes #105

merged 1 commit into from
Jul 10, 2023

Conversation

krassowski
Copy link
Contributor

This is needed to have the close icon in JupyterLab 4.0

@krassowski
Copy link
Contributor Author

Bump?

@kushalkolar
Copy link

kushalkolar commented Jul 7, 2023

Is this the only change required for v4?

related #109 , @clewis7

@krassowski
Copy link
Contributor Author

No, one would also need to run the extension migration script see, https://jupyterlab.readthedocs.io/en/stable/extension/extension_migration.html - I would be happy to review a PR if you would like to do that.

This PR predates this upgrade script.

@vidartf vidartf merged commit 8f02f56 into jupyter-widgets:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants