Fix message throttle by making a copy of the callbacks dict #3485
Conversation
|
|
This partially reverts changes from jupyter-widgets#3470. I think the underlying assumptions around send_sync_message and callbacks are: 1. send_sync_message is only ever called once per message. When the original sync happens, either we put the message on the queue or we send it immediately, and the callback modifications happen only when we actually send the message. 2. There was an implicit assumption in the send_sync_message code is that the callbacks object passed in is a new object unique to this message, i.e., we aren't modifying a global object, that then we'll modify again later. I think assumption 2 is sometimes not true, so this guards against it by making a (2-deep) copy of the callbacks object before modifying and using it.
|
Hi Jason, I tried a (lodash) clone, but that didn't work, this solution is much better. cheers, Maarten |
|
@meeseeksdev please backport to 7.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
|
Backported in #3494 |
Fixes #3469 in a different way from #3470.
This partially reverts code changes from #3470, but leaves the tests.
I think the underlying assumptions around send_sync_message and callbacks are:
I think assumption 2 is sometimes not true, so this guards against it by making a (2-deep) copy of the callbacks object before modifying and using it.