Backport echo_update messages to 7.x #3400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This backports the combination of jupyter-widgets#3195 and jupyter-widgets#3394.
We have to explicitly use hold_sync in the test, since jupyter-widgets#3271 was targeted to 8.0 and not backported to 7.x.
We do this for backwards compatibility, so there are no surprises. During 7.x, you can opt in to widget update echoing by setting the environment variable or by setting the module-level variable.
|
@vidartf - from our discussion yesterday, I now have two test files for testing setting widget state. One is exactly the one that we had before (test_set_state.py), and the other (test_set_state_echo.py) sets the echoing to happen and tests the new results from master. |
3 tasks
|
@vidartf - I think this is ready for review too. This backports the echo_update message to 7.x |
As the code in test_set_state_noecho was mostly a copy, I tried to make it more DRY.
vidartf
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the combination of #3195 and #3394 to 7.x.
It's probably easiest to compare this PR with the squashed commit containing #3195 and #3394, i.e., 56df723