Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSS class names for lumino #3366

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Conversation

vidartf
Copy link
Member

@vidartf vidartf commented Feb 1, 2022

Resolves #3357.

I also made sure that the <DEPRECATED> tags formed open/close pairs for easier processing in the future.

As discussed in the dev meeting, this also renames some of the internal CSS class names to avoid conflicting with the phosphor prefix.

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Binder 👈 Launch a binder notebook on branch vidartf/ipywidgets/lm-css

@vidartf vidartf added this to the 8.0 milestone Feb 8, 2022
@jasongrout
Copy link
Member

Thanks!

@jasongrout jasongrout merged commit 7078bc5 into jupyter-widgets:master Feb 8, 2022
@vidartf vidartf deleted the lm-css branch February 9, 2022 17:59
@martinRenou
Copy link
Member

meeseeksdev please backport to 7.x

Copy link

lumberbot-app bot commented Jul 26, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 7.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 7078bc549bb859682cda99adfb5d2e9126ac531d
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #3366: Update CSS class names for lumino'
  1. Push to a named branch:
git push YOURFORK 7.x:auto-backport-of-pr-3366-on-7.x
  1. Create a PR against branch 7.x, I would have named this PR:

"Backport PR #3366 on branch 7.x (Update CSS class names for lumino)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition from Phosphor CSS class names to Lumino names
3 participants