Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to comment on PRs with a binder link #3148

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

ianhi
Copy link
Contributor

@ianhi ianhi commented Mar 4, 2021

This PR will add an action that (hopefully) will comment on PRs with a binder link to allow easy testing of the PR.

@jasongrout
Copy link
Member

Awesome, let's try it out!

@jasongrout jasongrout merged commit 98e6c86 into jupyter-widgets:master Mar 4, 2021
@ianhi ianhi deleted the binder-on-prs branch March 4, 2021 21:35
@ianhi ianhi mentioned this pull request Mar 4, 2021
@jtpio
Copy link
Member

jtpio commented Mar 5, 2021

Nice, thanks!

Should we also provide a postBuild file to explicitely install jupyterlab_widgets and widgetsnbextension from source?

It looks like they are installed from PyPI otherwise?

ipywidgets/setup.cfg

Lines 42 to 43 in 98e6c86

widgetsnbextension~=4.0a0
jupyterlab_widgets~=2.0a0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants