-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8.0.5 no longer lists ipykernel as an install dependency #3731
Comments
Hi Stefan, Yes, that's a feature. Since ipywidgets does not/should not make a decision on which kernel implementation to use. Looking at a failure ( https://github.com/scikit-image/scikit-image/actions/runs/4482139559/jobs/7879781176?pr=6844 ) cc @martinRenou |
I just hit the same bug in MNE-Python tests. I plan to add FWIW the error is cryptic:
So it would be nice to at least detect the problem and throw an informative error. |
Yeah, that's not great. I think ipython/comm#13 already solves most of the pain. |
@maartenbreddels - I think you're right that we should have waited until 8.1 to make this change (especially looking at the number of issues linked here). What do you think of releasing an 8.0.6 with the dependency back in (so people can upgrade to the patch release with no breakage), and an 8.1.0 with the dependency removed, and noted in the release notes? |
For me this was showing up as the rather cryptic
and it took a couple of hours to rebuild an environment where I could reproduce this. I might put something up on StackOverflow about this, since none of the existing questions seem to recognize this change as a possible cause. |
This broke the scikit-image docs build.
See 785d159
The text was updated successfully, but these errors were encountered: