Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0.5 no longer lists ipykernel as an install dependency #3731

Open
stefanv opened this issue Mar 21, 2023 · 5 comments
Open

8.0.5 no longer lists ipykernel as an install dependency #3731

stefanv opened this issue Mar 21, 2023 · 5 comments

Comments

@stefanv
Copy link

stefanv commented Mar 21, 2023

This broke the scikit-image docs build.

See 785d159

@maartenbreddels
Copy link
Member

Hi Stefan,

Yes, that's a feature. Since ipywidgets does not/should not make a decision on which kernel implementation to use.
Writing this out, I am unsure we should have done this in a fix release however.

Looking at a failure ( https://github.com/scikit-image/scikit-image/actions/runs/4482139559/jobs/7879781176?pr=6844 )
I am not sure if I'm happy with the situation either.
I think we should either have the comm package as a dependency or ipykernel, so ipywidgets works out of the box outside of a kernel.

cc @martinRenou

@larsoner
Copy link

I just hit the same bug in MNE-Python tests. I plan to add ipykernel as a dependency in the same place as ipywidgets for now.

FWIW the error is cryptic:

_______________ ERROR collecting mne/viz/backends/_notebook.py ________________
mne\viz\backends\_notebook.py:53: in <module>
    _BASE_KWARGS = dict(layout=Layout(
C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\site-packages\ipywidgets\widgets\widget_layout.py:86: in __init__
    super().__init__(**kwargs)
C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\site-packages\ipywidgets\widgets\widget.py:504: in __init__
    self.open()
C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\site-packages\ipywidgets\widgets\widget.py:535: in open
    self.comm = create_comm(**args)
C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\site-packages\comm\__init__.py:27: in _create_comm
    raise NotImplementedError("Cannot ")
E   NotImplementedError: Cannot

So it would be nice to at least detect the problem and throw an informative error.

@maartenbreddels
Copy link
Member

Yeah, that's not great. I think ipython/comm#13 already solves most of the pain.

kandersolar added a commit to openpvtools/pv-foss-engagement that referenced this issue Mar 22, 2023
jarrodmillman added a commit to jarrodmillman/scikit-image that referenced this issue Mar 23, 2023
jarrodmillman added a commit to jarrodmillman/scikit-image that referenced this issue Mar 23, 2023
jenshnielsen added a commit to jenshnielsen/Qcodes that referenced this issue Mar 27, 2023
@jasongrout
Copy link
Member

@maartenbreddels - I think you're right that we should have waited until 8.1 to make this change (especially looking at the number of issues linked here). What do you think of releasing an 8.0.6 with the dependency back in (so people can upgrade to the patch release with no breakage), and an 8.1.0 with the dependency removed, and noted in the release notes?

@GregIthaca
Copy link

For me this was showing up as the rather cryptic

jupyter_client.kernelspec.NoSuchKernel: No such kernel named python3

and it took a couple of hours to rebuild an environment where I could reproduce this. I might put something up on StackOverflow about this, since none of the existing questions seem to recognize this change as a possible cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants